[PATCH] D23727: [Profile] SelectInst instrumentation Support in IR-PGO

[Sanjoy Das via llvm-commits]

sanjoy added a subscriber: sanjoy.
sanjoy added a comment.

Random drop by comment inline.


================
Comment at: llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp:228
@@ +227,3 @@
+  auto *IncWithStep = dyn_cast<InstrProfIncrementInstStep>(Inc);
+  if (IncWithStep)
+    return IncWithStep->getStep();
----------------
One out of context comment here -- can't this logic be part of `dyn_cast` via the `classof` you addd to `InstrProfIncrementInstStep`?


Repository:
  rL LLVM

https://reviews.llvm.org/D23727