[PATCH] D24540: [AArch64] Add Cavium ThunderX subtarget support.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 14:45:18 PDT 2016


echristo added a comment.

Seems a little light on testing, but then again there's not a lot of reason to add tons of identical testing (though we have it right now).

TargetParser does need tests.

Probably wants a clang patch as well?

-eric


================
Comment at: lib/Target/AArch64/AArch64Subtarget.h:48
@@ -48,1 +47,3 @@
+    Vulcan,
+    ThunderX
   };
----------------
Can you add a trailing , to this so we don't have to worry in the future?


Repository:
  rL LLVM

https://reviews.llvm.org/D24540





More information about the llvm-commits mailing list