[PATCH] D24731: [GC] Don't crash when printing gc'd sections with no name and no associated file
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 19 10:39:42 PDT 2016
davide added a comment.
C->getFile() == nullptr
true
F->getName()
"LLD-INTERNAL-combined-lto-object"
[Raw View]: {Data=0x0000000144483f18 "LLD-INTERNAL-combined-lto-object" Length=32 }
It comes from the combined LTO object.
The input section name is empty anyway so I'm not entirely sure what buys us in this particular circumstance.
In general, anyway, yes, I think <internal> is a better diagnostic if we don't have the filename available. Do you agree?
https://reviews.llvm.org/D24731
More information about the llvm-commits
mailing list