[PATCH] D24685: Simplify SORT and --sort-section command line option handling.
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 19 10:11:01 PDT 2016
rafael added a subscriber: rafael.
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.
I do like this new one better, but I think it needs a few more comments.
In particular, mention that the command line replaces the inner sort if not set explicitly.
BTW, this and the previous code would crash if SORT_NONE was the inner sort, no?
================
Comment at: ELF/LinkerScript.cpp:165
@@ -164,1 +164,3 @@
+void sortSections(std::vector<InputSectionData *> &Sections,
+ SortSectionPolicy K) {
----------------
static
https://reviews.llvm.org/D24685
More information about the llvm-commits
mailing list