[lld] r281754 - Recommit r281721 "[ELF] - Linkerscript: implement EXCLUDE_FILE in the middle of a input section description."

[Rafael Espíndola via llvm-commits]

On 16 September 2016 at 16:07, George Rimar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> >I didn't read the entire patch yet, but why did you use <list>? It is a
> doubly-linked list and slower than the vector, so you don't >want to use it
> unless you really want doubly-linked lists.
>
> Please look at my comment about this at review page, it is a workaround
> for compiler bug. No difference with list here in plan of speed because 99%
> of time this container has single element.
>


Can you add a comment saying that list is used to avoid a compiler
(libc++?) bug? std::vector is far more common, so it is nice to justify why
a list is used.


Thanks,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160919/0d063ca9/attachment.html>