[PATCH] D24714: [MC] Support skip and count for .incbin directive
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 18 21:30:27 PDT 2016
davide added inline comments.
================
Comment at: lib/MC/MCParser/AsmParser.cpp:4407-4411
@@ +4406,7 @@
+ if (getLexer().isNot(AsmToken::EndOfStatement)) {
+ if (parseToken(AsmToken::Comma,
+ "unexpected token in '.incbin' directive") ||
+ parseAbsoluteExpression(Skip))
+ return true;
+
+ if (getLexer().isNot(AsmToken::EndOfStatement)) {
----------------
this and the lines at 4413-4417 are identical. Can you factor out in a common helper?
Repository:
rL LLVM
https://reviews.llvm.org/D24714
More information about the llvm-commits
mailing list