[llvm] r281876 - [llvm-cov] Make a helper method static for re-use (NFC)
Vedant Kumar via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 18 17:38:26 PDT 2016
Author: vedantk
Date: Sun Sep 18 19:38:25 2016
New Revision: 281876
URL: http://llvm.org/viewvc/llvm-project?rev=281876&view=rev
Log:
[llvm-cov] Make a helper method static for re-use (NFC)
Modified:
llvm/trunk/tools/llvm-cov/CoverageReport.cpp
llvm/trunk/tools/llvm-cov/CoverageReport.h
llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp
Modified: llvm/trunk/tools/llvm-cov/CoverageReport.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/CoverageReport.cpp?rev=281876&r1=281875&r2=281876&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/CoverageReport.cpp (original)
+++ llvm/trunk/tools/llvm-cov/CoverageReport.cpp Sun Sep 18 19:38:25 2016
@@ -259,8 +259,9 @@ void CoverageReport::renderFunctionRepor
}
std::vector<FileCoverageSummary>
-CoverageReport::prepareFileReports(FileCoverageSummary &Totals,
- ArrayRef<StringRef> Files) const {
+CoverageReport::prepareFileReports(const coverage::CoverageMapping &Coverage,
+ FileCoverageSummary &Totals,
+ ArrayRef<StringRef> Files) {
std::vector<FileCoverageSummary> FileReports;
unsigned LCP = 0;
if (Files.size() > 1)
@@ -304,7 +305,7 @@ void CoverageReport::renderFileReports(r
void CoverageReport::renderFileReports(raw_ostream &OS,
ArrayRef<StringRef> Files) const {
FileCoverageSummary Totals("TOTAL");
- auto FileReports = prepareFileReports(Totals, Files);
+ auto FileReports = prepareFileReports(Coverage, Totals, Files);
std::vector<StringRef> Filenames;
for (const FileCoverageSummary &FCS : FileReports)
Modified: llvm/trunk/tools/llvm-cov/CoverageReport.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/CoverageReport.h?rev=281876&r1=281875&r2=281876&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/CoverageReport.h (original)
+++ llvm/trunk/tools/llvm-cov/CoverageReport.h Sun Sep 18 19:38:25 2016
@@ -35,9 +35,9 @@ public:
void renderFunctionReports(ArrayRef<StringRef> Files, raw_ostream &OS);
/// Prepare file reports for the files specified in \p Files.
- std::vector<FileCoverageSummary>
- prepareFileReports(FileCoverageSummary &Totals,
- ArrayRef<StringRef> Files) const;
+ static std::vector<FileCoverageSummary>
+ prepareFileReports(const coverage::CoverageMapping &Coverage,
+ FileCoverageSummary &Totals, ArrayRef<StringRef> Files);
/// Render file reports for every unique file in the coverage mapping.
void renderFileReports(raw_ostream &OS) const;
Modified: llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp?rev=281876&r1=281875&r2=281876&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp (original)
+++ llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp Sun Sep 18 19:38:25 2016
@@ -375,11 +375,11 @@ Error CoveragePrinterHTML::createIndexFi
OSRef << tag(CreatedTimeTag, escape(Opts.CreatedTimeStr, Opts));
// Emit a table containing links to reports for each file in the covmapping.
- CoverageReport Report(Opts, Coverage);
OSRef << BeginCenteredDiv << BeginTable;
emitColumnLabelsForIndex(OSRef);
FileCoverageSummary Totals("TOTALS");
- auto FileReports = Report.prepareFileReports(Totals, SourceFiles);
+ auto FileReports =
+ CoverageReport::prepareFileReports(Coverage, Totals, SourceFiles);
for (unsigned I = 0, E = FileReports.size(); I < E; ++I)
emitFileSummary(OSRef, SourceFiles[I], FileReports[I]);
emitFileSummary(OSRef, "Totals", Totals, /*IsTotals=*/true);
More information about the llvm-commits
mailing list