[PATCH] D24548: Add AArch64 unit tests

[Renato Golin via llvm-commits]

rengolin added reviewers: t.p.northover, jmolloy.
rengolin added a comment.

Hi Diana,

Nice usage of lambdas.

I'm guessing that the MIR snippet you have in `runChecks()` is the bare minimum to make it parse, in which case, any sequence of machine instructions would work with that pattern. For now, that being inside an anonymous namespace in the AArch64 part of the tests is ok, but if more targets start using this pattern (which I think it's a good thing), we should be moving this up somewhere. Not in this patch, but maybe a comment would be good.

Overall, LGTM, but I'll let someone else have a look, too.

cheers,
--renato


================
Comment at: unittests/Target/AArch64/InstSizes.cpp:88
@@ +87,3 @@
+              EXPECT_EQ(16u, II.getInstSizeInBytes(*I));
+
+              ++I;
----------------
why the extra space?


https://reviews.llvm.org/D24548