[PATCH] D24699: [asan] Allow re-exec in instrumented unit tests on Darwin (fix unit tests on macOS <=10.10)

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 17 01:59:23 PDT 2016


kubabrecka created this revision.
kubabrecka added reviewers: kcc, eugenis, filcab, dvyukov.
kubabrecka added subscribers: ab, llvm-commits, zaks.anna.
kubabrecka added a project: Sanitizers.
Herald added a subscriber: kubabrecka.

This fixes <https://llvm.org/bugs/show_bug.cgi?id=30285>.  On macOS 10.10 and lower, instrumented unit tests still need to be able to re-exec to make interceptors work.

https://reviews.llvm.org/D24699

Files:
  lib/asan/tests/asan_test_main.cc

Index: lib/asan/tests/asan_test_main.cc
===================================================================
--- lib/asan/tests/asan_test_main.cc
+++ lib/asan/tests/asan_test_main.cc
@@ -28,7 +28,11 @@
 
 namespace __sanitizer {
 bool ReexecDisabled() {
+#if __has_feature(address_sanitizer)
+  return false;  // Allow re-exec in instrumented unit tests.
+#else
   return true;
+#endif
 }
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24699.71728.patch
Type: text/x-patch
Size: 393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160917/3c1db424/attachment.bin>


More information about the llvm-commits mailing list