[lld] r281776 - Rename SortSectionPolicy::IgnoreConfig to None.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 17 00:55:00 PDT 2016


> // For --sort-section and linkerscript sorting rules.
>-enum class SortSectionPolicy { None, IgnoreConfig, Alignment, Name, Priority };
>+enum class SortSectionPolicy { Default, None, Alignment, Name, Priority };

Honestly I find this renaming very confusing.
If we are talking about policy of sorting, then clear logic would be that None is absence of sorting,
and Default is sorting by default, which is in out case also absence of sorting, but can be something different.

But None here means very different and just reflects the command name of linkerscript,
(which has just wrong name probably) and not the policy at all.

 George.


More information about the llvm-commits mailing list