[PATCH] D24650: [ELF] - Linkerscript: PR30387 - cannot handle EXCLUDE_FILE in the middle of a input section description.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 19:49:05 PDT 2016


ruiu added a comment.

I just spent a few hours to clean up the linker script code and realized that it is getting hard to read because of lack of comments. There are bunch of functions and variables that are not obvious about what they are for, and the only way to understand it is reading code. The code may be easy to read if you already know what the code is doing, but our bar should be higher. I'll add more comments and refactor for simplification, but please write more comments in the first place to describe what you are trying to do for what purpose.


Repository:
  rL LLVM

https://reviews.llvm.org/D24650





More information about the llvm-commits mailing list