[PATCH] D24692: Mark ELF sections whose name start with .note as note
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 16 18:08:00 PDT 2016
ruiu added inline comments.
================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:154
@@ -153,1 +153,3 @@
static unsigned getELFSectionType(StringRef Name, SectionKind K) {
+ if (Name.startswith(".note"))
+ return ELF::SHT_NOTE;
----------------
phosek wrote:
> ruiu wrote:
> > Shouldn't this be `Name == ".note" || Name.startswith(".note.")`?
> That's definitely more strict so it's probably a better solution. The logic in `lib/MC/MCParser/ELFAsmParser.cpp` uses `Name.startswith(".note")`, shall I update that as well?
I don't know the answer, but I *think* that's the right thing to do.
Repository:
rL LLVM
https://reviews.llvm.org/D24692
More information about the llvm-commits
mailing list