[PATCH] D23778: [ThinLTO] Move ThinLTOCodeGenerator implementation to target the new LTO API.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 11:00:50 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:363
@@ +362,3 @@
+      std::unique_ptr<raw_pwrite_stream> getStream() override {
+        report_fatal_error("Unexpected");
+      }
----------------
tejohnson wrote:
> I'm a little confused about what this interface is used for - why are we asserting if there is any stream requested?
I'll make it more clear. The ThinLTO code generator is not supposed to have any non-ThinLTO file at this point.
In the libLTO C API, the LTO and ThinLTO path are not unified at this time.


https://reviews.llvm.org/D23778





More information about the llvm-commits mailing list