[llvm] r281744 - Fix NameAnonFunctions pass: for ThinLTO we need to rename global variables as well

[Mehdi Amini via llvm-commits]

Author: mehdi_amini
Date: Fri Sep 16 11:56:25 2016
New Revision: 281744

URL: http://llvm.org/viewvc/llvm-project?rev=281744&view=rev
Log:
Fix NameAnonFunctions pass: for ThinLTO we need to rename global variables as well

A follow-up patch will rename this pass and the source file accordingly,
but I figured the non-NFC change will be easier to spot in isolation.

Differential Revision: https://reviews.llvm.org/D24641

Modified:
    llvm/trunk/lib/Transforms/Utils/NameAnonFunctions.cpp
    llvm/trunk/test/Transforms/NameAnonFunctions/rename.ll

Modified: llvm/trunk/lib/Transforms/Utils/NameAnonFunctions.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/NameAnonFunctions.cpp?rev=281744&r1=281743&r2=281744&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/NameAnonFunctions.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/NameAnonFunctions.cpp Fri Sep 16 11:56:25 2016
@@ -67,12 +67,17 @@ bool llvm::nameUnamedFunctions(Module &M
   bool Changed = false;
   ModuleHasher ModuleHash(M);
   int count = 0;
-  for (auto &F : M) {
-    if (F.hasName())
-      continue;
-    F.setName(Twine("anon.") + ModuleHash.get() + "." + Twine(count++));
+  auto RenameIfNeed = [&] (GlobalValue &GV) {
+    if (GV.hasName())
+      return;
+    GV.setName(Twine("anon.") + ModuleHash.get() + "." + Twine(count++));
     Changed = true;
-  }
+  };
+  for (auto &GO : M.global_objects())
+    RenameIfNeed(GO);
+  for (auto &GA : M.aliases())
+    RenameIfNeed(GA);
+
   return Changed;
 }
 

Modified: llvm/trunk/test/Transforms/NameAnonFunctions/rename.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/NameAnonFunctions/rename.ll?rev=281744&r1=281743&r2=281744&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/NameAnonFunctions/rename.ll (original)
+++ llvm/trunk/test/Transforms/NameAnonFunctions/rename.ll Fri Sep 16 11:56:25 2016
@@ -11,6 +11,8 @@ define internal void @bar() {
     ret void
 }
 
+; CHECK: @anon.acbd18db4cc2f85cedef654fccc4a4d8.3 = global i8 0
+; CHECK: @anon.acbd18db4cc2f85cedef654fccc4a4d8.4 = alias i8, i8* @anon.acbd18db4cc2f85cedef654fccc4a4d8.3
 ; CHECK: define void @anon.acbd18db4cc2f85cedef654fccc4a4d8.0()
 ; CHECK: define void @anon.acbd18db4cc2f85cedef654fccc4a4d8.1()
 ; CHECK: define void @anon.acbd18db4cc2f85cedef654fccc4a4d8.2()
@@ -25,3 +27,7 @@ define void @2() {
     ret void
 }
 
+
+ at 3 = global i8 0
+
+ at 4 = alias i8, i8 *@3