[PATCH] D23799: [ESan][MIPS] Adds support for MIPS64

Sagar Thakur via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 23:57:49 PDT 2016


slthakur added inline comments.

================
Comment at: test/esan/TestCases/mmap-shadow-conflict.c:13
@@ +12,3 @@
+#else
+  void *Map = mmap((void *)0x0000016000000000ULL, 0x1000, PROT_READ,
+#endif
----------------
zhaoqin wrote:
> Are you sure the code can be compiled on non-mips64?
> Please at least build and test on one non-mips64 (e.g., x86_64) machine
Sorry, there was a mistake in uploading of the diff. This test case was tested on x86_64 with a different diff which included this line of mmap and all tests were passing. I just uploaded the wrong diff here.


Repository:
  rL LLVM

https://reviews.llvm.org/D23799





More information about the llvm-commits mailing list