[PATCH] D24641: Fix NameAnonFunctions pass: for ThinLTO we need to rename global variables as well

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 17:34:52 PDT 2016


mehdi_amini added a comment.

In https://reviews.llvm.org/D24641#544320, @pcc wrote:

> Do aliases and ifuncs also need to be renamed? I know that at least unnamed aliases are legal (https://reviews.llvm.org/rL239921) but I don't know about ifuncs.


I didn't know alias could be unnamed, reminds me that I need to fix the alias representation (and forbid unnamed at the same time).

So now I need another iterator for all Module globalvalues... ;)

I feel ifunc would break ThinLTO, I don't remember seeing any test for that (I'm not sure they work on MachO either).


https://reviews.llvm.org/D24641





More information about the llvm-commits mailing list