[PATCH] D24617: [LTO] Prevent asm undefined references to be dropped from the output

[Teresa Johnson via llvm-commits]

On Thu, Sep 15, 2016 at 4:38 PM, Davide Italiano <davide at freebsd.org> wrote:

> On Thu, Sep 15, 2016 at 2:16 PM, Mehdi AMINI via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > mehdi_amini added inline comments.
> >
> > ================
> > Comment at: lib/LTO/LTO.cpp:368
> > @@ -367,3 +382,3 @@
> >    assert(ResI == Res.end());
> >
> >    return RegularLTO.Mover->move(Obj->takeModule(), Keep,
> > ----------------
> > Why don't you update compiler.used here before merging? This way the
> StringSet could be local to this function and not global to the LTO
> class/lifetime I believe.
> >
>
> One minor complication is that we don't have a TargetMachine at that
> point. We could create a TargetMachine earlier and pass around. Or we
> could create TargetMachine two times, but that seems a little bit
> weird to me.
> In general, I don't see that as an improvement, but I'd like to hear
> what others have to say.
>

How about using the same approach in lto::backend as you have added to
thinBackend?

Teresa

>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
>



-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160915/80de309c/attachment.html>