[PATCH] D24622: LTO: Simplify caching interface.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 16:21:10 PDT 2016


pcc added inline comments.

================
Comment at: include/llvm/LTO/LTO.h:309
@@ -309,1 +308,3 @@
+  /// AddFile functions to add native object files to the link.
+  Error run(AddStreamFn AddStream, AddFileFn AddFile);
 
----------------
mehdi_amini wrote:
> mehdi_amini wrote:
> > I'm not in favor of this, currently a client that don't need caching does not need to handle file input.
> > I'm not in favor of this, currently a client that don't need caching does not need to handle file input....
> 
> ... currently. 
> 
Handling file input is pretty much what linkers do all the time, so I wouldn't consider it to be particularly burdensome :)

Is there any specific client you have in mind where this would be a problem?


https://reviews.llvm.org/D24622





More information about the llvm-commits mailing list