[PATCH] D24617: [LTO] Prevent asm undefined references to be dropped from the output
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 15 14:16:46 PDT 2016
mehdi_amini added inline comments.
================
Comment at: lib/LTO/LTO.cpp:368
@@ -367,3 +382,3 @@
assert(ResI == Res.end());
return RegularLTO.Mover->move(Obj->takeModule(), Keep,
----------------
Why don't you update compiler.used here before merging? This way the StringSet could be local to this function and not global to the LTO class/lifetime I believe.
https://reviews.llvm.org/D24617
More information about the llvm-commits
mailing list