[PATCH] D24620: Fix autoupgrade logic for Objective-C class properties module flag

Manman Ren via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 13:50:38 PDT 2016


manmanren added a comment.

Thanks for working on this!

This makes sense. I wonder what happens when we downgrade. Will the class properties in the new code no longer functional?

Manman


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:1566
@@ -1565,3 +1565,3 @@
   // upgrade ObjC bitcodes to contain a "Objective-C Class Properties" module
   // flag of value 0, so we can correclty report error when trying to link
   // an ObjC bitcode without this module flag with an ObjC bitcode with this
----------------
Please update the comment.


https://reviews.llvm.org/D24620





More information about the llvm-commits mailing list