[PATCH] D24617: [LTO] Prevent asm undefined references to be dropped from the output

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D24617#543995, @mehdi_amini wrote:

> The problem is that after merge, if two local symbols have a name conflict in LTO, one of them will be renamed.
>  I'd like to see a test with such cases.


Hmm, so how would we catch/handle this? The uses from module level assembly won't be renamed, right? (I know that is an issue for inline assembly). That seems orthogonal to the issue of making sure their defs are not dropped by updating llvm.compiler.used appropriately (which could be fixed by doing what I suggested for ThinLTO - call CollectAsmUndefinedRefs from the backend).


https://reviews.llvm.org/D24617