[llvm] r281649 - [AArch64] Support for FP FMA when -ffp-contract=fast

Evandro Menezes via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 12:55:25 PDT 2016


Author: evandro
Date: Thu Sep 15 14:55:23 2016
New Revision: 281649

URL: http://llvm.org/viewvc/llvm-project?rev=281649&view=rev
Log:
[AArch64] Support for FP FMA when -ffp-contract=fast

Currently, the machine combiner can proceed matching when -ffast-math is on.
It should also match when only -ffp-contract=fast is specified as was the
case before when DAGCombiner was doing the job.

Patch by: Abderrazek Zaafrani <a.zaafrani at samsung.com>.

Differential Revision: https://reviews.llvm.org/D24366

Added:
    llvm/trunk/test/CodeGen/AArch64/arm64-fma-combine-with-fpfusion.ll
Modified:
    llvm/trunk/lib/Target/AArch64/AArch64InstrInfo.cpp

Modified: llvm/trunk/lib/Target/AArch64/AArch64InstrInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64InstrInfo.cpp?rev=281649&r1=281648&r2=281649&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64InstrInfo.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64InstrInfo.cpp Thu Sep 15 14:55:23 2016
@@ -2901,6 +2901,8 @@ static bool isCombineInstrCandidate64(un
 // FP Opcodes that can be combined with a FMUL
 static bool isCombineInstrCandidateFP(const MachineInstr &Inst) {
   switch (Inst.getOpcode()) {
+  default:
+    break;
   case AArch64::FADDSrr:
   case AArch64::FADDDrr:
   case AArch64::FADDv2f32:
@@ -2911,9 +2913,9 @@ static bool isCombineInstrCandidateFP(co
   case AArch64::FSUBv2f32:
   case AArch64::FSUBv2f64:
   case AArch64::FSUBv4f32:
-    return Inst.getParent()->getParent()->getTarget().Options.UnsafeFPMath;
-  default:
-    break;
+		TargetOptions Options = Inst.getParent()->getParent()->getTarget().Options; 
+    return (Options.UnsafeFPMath || 
+				    Options.AllowFPOpFusion == FPOpFusion::Fast);
   }
   return false;
 }

Added: llvm/trunk/test/CodeGen/AArch64/arm64-fma-combine-with-fpfusion.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/arm64-fma-combine-with-fpfusion.ll?rev=281649&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/arm64-fma-combine-with-fpfusion.ll (added)
+++ llvm/trunk/test/CodeGen/AArch64/arm64-fma-combine-with-fpfusion.ll Thu Sep 15 14:55:23 2016
@@ -0,0 +1,12 @@
+; RUN: llc < %s -mtriple=aarch64-linux-gnu -fp-contract=fast | FileCheck %s
+define float @mul_add(float %a, float %b, float %c) local_unnamed_addr #0 {
+; CHECK-LABEL: %entry
+; CHECK: fmadd {{s[0-9]+}}, {{s[0-9]+}}, {{s[0-9]+}}
+  entry:
+    %mul = fmul float %a, %b
+    %add = fadd float %mul, %c
+    ret float %add
+}
+
+attributes #0 = { norecurse nounwind readnone "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+neon" "unsafe-fp-math"="false" "use-soft-float"="false" }
+




More information about the llvm-commits mailing list