[PATCH] D24616: [ELF] Improve section GC for comdat groups
Eugene Leviant via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 15 12:32:00 PDT 2016
evgeny777 added a comment.
Let's elaborate the idea. The main problem is that symbol 'D' inside resolveReloc() may point to InputSectionBase<ELFT>::Discarded. This happens because comdat group is added to only one object file and causes crash in GC, because forEachSuccessor implicitly casts Discarded to InputSection<ELFT> and tries to fetch relocs from it. How this 'GroupMembers' vector would help?
Repository:
rL LLVM
https://reviews.llvm.org/D24616
More information about the llvm-commits
mailing list