[PATCH] D24617: [LTO] Prevent asm undefined references to be dropped from the output

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 12:20:50 PDT 2016


davide added inline comments.

================
Comment at: lib/LTO/LTOBackend.cpp:291
@@ +290,3 @@
+  // off asm undefined references.
+  updateCompilerUsed(*Mod, *TM, AsmUndefinedRefs);
+
----------------
tejohnson wrote:
> Ditto in thinBackend below
thinBackend() is also used by clang and it's not entirely clear to me what should I pass to it as AsmUndefinedReferences. If you know that off of your mind, I can change it. Otherwise I can commit the patch as is for full LTO and you can modify for thin accordingly (sorry, my knowledge of ThinLTO is still rather limited, and I don't want to delay this further).


https://reviews.llvm.org/D24617





More information about the llvm-commits mailing list