[PATCH] D23363: [compiler-rt] Add support for the dynamic shadow allocation

[Etienne Bergeron via llvm-commits]

etienneb added a comment.

thx, it was a good catch.
The build was broken in debug. Optimisation was taking away the need for FindAvailableMemoryAddress.


================
Comment at: lib/asan/asan_rtl.cc:472
@@ +471,3 @@
+
+    shadow_start = FindAvailableMemoryRange(space_size, alignment, granularity);
+    CHECK_NE((uptr)0, shadow_start);
----------------
vitalybuka wrote:
> Not sure how this going to link. This code is going to be compiled for all platforms, but 
> FindAvailableMemoryRange is defined only for windows.
> Probably we need some default {return nulltpr;} implementation.
> 
It was compiling on linux because of the compiler optimisaiton.
This is a good catch. Thx!


https://reviews.llvm.org/D23363