[compiler-rt] r281619 - Really fix the Windows sanitizer build

[Reid Kleckner via llvm-commits]

Ah, but that code is #if CAN_SANITIZE_LEAKS, so when the DLL thunk tries to
look it up, it fails and crashes.

On Thu, Sep 15, 2016 at 11:25 AM, Kostya Serebryany <kcc at google.com> wrote:

>
>
> On Thu, Sep 15, 2016 at 11:24 AM, Reid Kleckner <rnk at google.com> wrote:
>
>> On Thu, Sep 15, 2016 at 11:04 AM, Kostya Serebryany <kcc at google.com>
>> wrote:
>>
>>>
>>>
>>> On Thu, Sep 15, 2016 at 8:39 AM, Reid Kleckner via llvm-commits <
>>> llvm-commits at lists.llvm.org> wrote:
>>>
>>>> Author: rnk
>>>> Date: Thu Sep 15 10:39:52 2016
>>>> New Revision: 281619
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=281619&view=rev
>>>> Log:
>>>> Really fix the Windows sanitizer build
>>>>
>>>> Don't list __sanitizer_print_memory profile as an INTERFACE_FUNCTION. It
>>>> is not exported by ASan; it is exported by user code.
>>>>
>>>
>>> What a second. What?
>>> __sanitizer_print_memory profile is defined in asan code?
>>>
>>
>> It's a hook defined by user code that asan calls into, right? ASan
>> doesn't provide a definition for it, so we shouldn't try to export it.
>>
>
> No.
> This is a function defined by asan:
> % grep __sanitizer_print_memory lib/asan/*cc
> lib/asan/asan_memory_profile.cc:// This file implements
> __sanitizer_print_memory_profile.
> lib/asan/asan_memory_profile.cc:void __sanitizer_print_memory_profile(uptr
> top_percent) {
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160915/e726e0da/attachment.html>