[PATCH] D23363: [compiler-rt] Add support for the dynamic shadow allocation
Vitaly Buka via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 15 11:26:48 PDT 2016
vitalybuka requested changes to this revision.
This revision now requires changes to proceed.
================
Comment at: lib/asan/asan_rtl.cc:472
@@ +471,3 @@
+
+ shadow_start = FindAvailableMemoryRange(space_size, alignment, granularity);
+ CHECK_NE((uptr)0, shadow_start);
----------------
Not sure how this going to link. This code is going to be compiled for all platforms, but
FindAvailableMemoryRange is defined only for windows.
Probably we need some default {return nulltpr;} implementation.
================
Comment at: lib/asan/asan_rtl.cc:662
@@ +661,3 @@
+// Called by a loaded DLL to initialize itself.
+void __asan_init_from_dll(
+ int *detect_stack_use_after_return,
----------------
please clang-format this
https://reviews.llvm.org/D23363
More information about the llvm-commits
mailing list