[PATCH] D24616: [ELF] Improve section GC for comdat groups

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 10:43:13 PDT 2016


evgeny777 created this revision.
evgeny777 added reviewers: ruiu, rafael.
evgeny777 added subscribers: grimar, llvm-commits.
evgeny777 set the repository for this revision to rL LLVM.
evgeny777 added a project: lld.

This patch fixes two things

1) If any section within comdat group is marked Live an entire group is marked live.
2) On some occasions GC may crash if symbol references section which is a member of comdat group. This happens in case compiler creates section relocation, i.e:

```
leaq    .text._Z3fooIiEvv(%rip), %rax
```


Repository:
  rL LLVM

https://reviews.llvm.org/D24616

Files:
  ELF/InputFiles.cpp
  ELF/InputFiles.h
  ELF/MarkLive.cpp
  test/ELF/Inputs/comdat-gc.s
  test/ELF/comdat-gc.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24616.71523.patch
Type: text/x-patch
Size: 8088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160915/d59ec9f9/attachment.bin>


More information about the llvm-commits mailing list