[PATCH] D24557: [Loop Vectorizer] Simplified GEP cloning. NFC.

Matthew Simpson via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 08:07:48 PDT 2016


mssimpso added a comment.

Regarding the "uniform" assertion, I had been assuming this is equivalent to Legal->isUniform(), but I took a look at the implementation of isUniform in LAI. Over there, we have something like:

  PSE.getSE()->isLoopInvariant(PSE.getSE()->getSCEV(Value), Loop);

Whereas here, we have something like:

  PSE.getSE()->isLoopInvariant(PSE.getSCEV(Value), Loop);

I'm not familiar enough with PSE to know what, if any, difference this might make.


Repository:
  rL LLVM

https://reviews.llvm.org/D24557





More information about the llvm-commits mailing list