[llvm] r281581 - [llvm-cov] Make a method name more accurate (NFC)
Vedant Kumar via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 14 21:46:00 PDT 2016
Author: vedantk
Date: Wed Sep 14 23:45:59 2016
New Revision: 281581
URL: http://llvm.org/viewvc/llvm-project?rev=281581&view=rev
Log:
[llvm-cov] Make a method name more accurate (NFC)
Modified:
llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp
llvm/trunk/tools/llvm-cov/SourceCoverageView.h
llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp
llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.h
llvm/trunk/tools/llvm-cov/SourceCoverageViewText.cpp
llvm/trunk/tools/llvm-cov/SourceCoverageViewText.h
Modified: llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp?rev=281581&r1=281580&r2=281581&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp (original)
+++ llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp Wed Sep 14 23:45:59 2016
@@ -169,7 +169,7 @@ void SourceCoverageView::addInstantiatio
void SourceCoverageView::print(raw_ostream &OS, bool WholeFile,
bool ShowSourceName, unsigned ViewDepth) {
if (WholeFile && getOptions().hasOutputDirectory())
- renderCellInTitle(OS, "Coverage Report");
+ renderTitle(OS, "Coverage Report");
renderViewHeader(OS);
Modified: llvm/trunk/tools/llvm-cov/SourceCoverageView.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageView.h?rev=281581&r1=281580&r2=281581&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/SourceCoverageView.h (original)
+++ llvm/trunk/tools/llvm-cov/SourceCoverageView.h Wed Sep 14 23:45:59 2016
@@ -240,9 +240,9 @@ protected:
virtual void renderInstantiationView(raw_ostream &OS, InstantiationView &ISV,
unsigned ViewDepth) = 0;
- /// \brief Render the project title, the report title \p CellText and the
- /// created time for the view.
- virtual void renderCellInTitle(raw_ostream &OS, StringRef CellText) = 0;
+ /// \brief Render \p Title, a project title if one is available, and the
+ /// created time.
+ virtual void renderTitle(raw_ostream &OS, StringRef CellText) = 0;
/// \brief Render the table header for a given source file.
virtual void renderTableHeader(raw_ostream &OS, unsigned FirstUncoveredLineNo,
Modified: llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp?rev=281581&r1=281580&r2=281581&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp (original)
+++ llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp Wed Sep 14 23:45:59 2016
@@ -588,11 +588,10 @@ void SourceCoverageViewHTML::renderInsta
OS << EndExpansionDiv;
}
-void SourceCoverageViewHTML::renderCellInTitle(raw_ostream &OS,
- StringRef CellText) {
+void SourceCoverageViewHTML::renderTitle(raw_ostream &OS, StringRef Title) {
if (getOptions().hasProjectTitle())
OS << tag(ProjectTitleTag, escape(getOptions().ProjectTitle, getOptions()));
- OS << tag(ReportTitleTag, escape(CellText, getOptions()));
+ OS << tag(ReportTitleTag, escape(Title, getOptions()));
if (getOptions().hasCreatedTime())
OS << tag(CreatedTimeTag,
escape(getOptions().CreatedTimeStr, getOptions()));
Modified: llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.h?rev=281581&r1=281580&r2=281581&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.h (original)
+++ llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.h Wed Sep 14 23:45:59 2016
@@ -78,7 +78,7 @@ class SourceCoverageViewHTML : public So
void renderRegionMarkers(raw_ostream &OS, CoverageSegmentArray Segments,
unsigned ViewDepth) override;
- void renderCellInTitle(raw_ostream &OS, StringRef CellText) override;
+ void renderTitle(raw_ostream &OS, StringRef Title) override;
void renderTableHeader(raw_ostream &OS, unsigned FirstUncoveredLineNo,
unsigned IndentLevel) override;
Modified: llvm/trunk/tools/llvm-cov/SourceCoverageViewText.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageViewText.cpp?rev=281581&r1=281580&r2=281581&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/SourceCoverageViewText.cpp (original)
+++ llvm/trunk/tools/llvm-cov/SourceCoverageViewText.cpp Wed Sep 14 23:45:59 2016
@@ -218,13 +218,12 @@ void SourceCoverageViewText::renderInsta
ISV.View->print(OS, /*WholeFile=*/false, /*ShowSourceName=*/true, ViewDepth);
}
-void SourceCoverageViewText::renderCellInTitle(raw_ostream &OS,
- StringRef CellText) {
+void SourceCoverageViewText::renderTitle(raw_ostream &OS, StringRef Title) {
if (getOptions().hasProjectTitle())
getOptions().colored_ostream(OS, raw_ostream::CYAN)
<< getOptions().ProjectTitle << "\n";
- getOptions().colored_ostream(OS, raw_ostream::CYAN) << CellText << "\n";
+ getOptions().colored_ostream(OS, raw_ostream::CYAN) << Title << "\n";
if (getOptions().hasCreatedTime())
getOptions().colored_ostream(OS, raw_ostream::CYAN)
Modified: llvm/trunk/tools/llvm-cov/SourceCoverageViewText.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageViewText.h?rev=281581&r1=281580&r2=281581&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/SourceCoverageViewText.h (original)
+++ llvm/trunk/tools/llvm-cov/SourceCoverageViewText.h Wed Sep 14 23:45:59 2016
@@ -71,7 +71,7 @@ class SourceCoverageViewText : public So
void renderRegionMarkers(raw_ostream &OS, CoverageSegmentArray Segments,
unsigned ViewDepth) override;
- void renderCellInTitle(raw_ostream &OS, StringRef CellText) override;
+ void renderTitle(raw_ostream &OS, StringRef Title) override;
void renderTableHeader(raw_ostream &OS, unsigned FirstUncoveredLineNo,
unsigned IndentLevel) override;
More information about the llvm-commits
mailing list