[PATCH] D24595: [lib/LTO] Remove now unneded hack for undefined symbols

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 17:34:11 PDT 2016


tejohnson added inline comments.

================
Comment at: lib/LTO/LTO.cpp:341
@@ -340,3 +340,1 @@
-    if (Sym.getFlags() & object::BasicSymbolRef::SF_Undefined)
-      continue;
     if (Res.Prevailing && GV) {
----------------
mehdi_amini wrote:
> I wonder if we should instead assert that we don't have an undefined symbol with a prevailing resolution.
That sounds like a great idea - that's what intrigued me in the first place and what I was trying to figure out in the debugger yesterday for PR30363.


https://reviews.llvm.org/D24595





More information about the llvm-commits mailing list