[PATCH] D23132: Add a new BitcodeSymbolTable abstraction for bitcode files, and migrate IRObjectFile, llvm-nm, and LTO to use it

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 16:04:20 PDT 2016


pcc added a comment.

Before reviewing the details of this patch, a higher level point (as discussed on IRC):

You've started with an implementation that takes bitcode and produces a symbol table data structure. I think a better starting point would be to take in-memory IR and produce a symbol table. This has the advantage of being more in line with the desired end state, where the symbol table is required, producers create a bitcode symbol table from in-memory IR, and consumers read the symbol table directly with no upgrade path from existing symbol tables.


https://reviews.llvm.org/D23132





More information about the llvm-commits mailing list