[PATCH] D24575: [compiler-rt] Set asan win 64-bits to use dynamic address for memory allocator

[Etienne Bergeron via llvm-commits]

etienneb added a comment.

I ran the test on win7, and it's working fine:

  D:\src\llvm\ninja64>ninja check-asan
  -- Testing: 543 tests, 16 threads --
  Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  Testing Time: 69.00s
    Expected Passes    : 377
    Expected Failures  : 16
    Unsupported Tests  : 150

But, on win7 I still need that extra patch:

  Index: lib/asan/asan_mapping.h
  ===================================================================
  --- lib/asan/asan_mapping.h     (revision 281512)
  +++ lib/asan/asan_mapping.h     (working copy)
  @@ -140,7 +140,7 @@
   static const u64 kFreeBSD_ShadowOffset32 = 1ULL << 30;  // 0x40000000
   static const u64 kFreeBSD_ShadowOffset64 = 1ULL << 46;  // 0x400000000000
   static const u64 kWindowsShadowOffset32 = 3ULL << 28;  // 0x30000000
  -static const u64 kWindowsShadowOffset64 = 1ULL << 45;  // 32TB
  +static const u64 kWindowsShadowOffset64 = 1ULL << 41;  // 32TB
  
   #define SHADOW_SCALE kDefaultShadowScale

Until we landed this:

  https://reviews.llvm.org/D24575
  https://reviews.llvm.org/D23354

As I get it, no build bots should be broken.
If not, please revert this patch and I'm gonna find the right way to make it happens.


https://reviews.llvm.org/D24575