[PATCH] D24492: [LTO] Switch to the new resolution-based API.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 11:48:48 PDT 2016


ruiu added a comment.

This patch contains complex code with almost no comment. Please explain in the code about what you are doing.


================
Comment at: ELF/SymbolTable.cpp:116-120
@@ -115,7 +206,50 @@
 
-  // Compile bitcode files.
-  Lto.reset(new BitcodeCompiler);
-  for (const std::unique_ptr<BitcodeFile> &F : BitcodeFiles)
-    Lto->add(*F);
-  std::vector<std::unique_ptr<InputFile>> IFs = Lto->compile();
 
----------------
Why don't you keep the old interface and replace only the content of LTO.cpp? I think that was a good separation.


https://reviews.llvm.org/D24492





More information about the llvm-commits mailing list