[PATCH] D24557: [Loop Vectorizer] Simplified GEP cloning. NFC.

[Michael Kuperstein via llvm-commits]

mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

Thanks Elena, this looks like a significant improvement.

Just to make sure I understood correctly, the reason this works is that for a consecutive GEP, each operand must be either uniform or consecutive (this holds for both ptr and non-ptr IVs), so getScalarValue(0, 0) always does the right thing?

The only thing I'm a bit concerned about is removing all the asserts. Perhaps it's worth adding a loop under #ifndef NDEBUG, that verifies this? But if you/Ayal/Matt don't think it's useful, I won't insist.
Other than that, LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D24557