[PATCH] D24483: Convert finite to builtin

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 10:30:16 PDT 2016


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM after you change the comment.


================
Comment at: include/clang/Basic/Builtins.def:922
@@ +921,3 @@
+LIBBUILTIN(finitel, "iLd", "fnc", "math.h", GNU_LANG)
+// The __finite* are coming from C++ (mathcalls.h)
+LIBBUILTIN(__finite, "id", "fnc", "math.h", ALL_LANGUAGES)
----------------
This comment isn't really clear... maybe something more like "glibc's math.h generates calls to __finite"?


https://reviews.llvm.org/D24483





More information about the llvm-commits mailing list