[PATCH] D24156: [CMake] Explicitly add --target option to compiler flags

[Renato Golin via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.

In https://reviews.llvm.org/D24156#541222, @fjricci wrote:

> It looks like this change won't break any of the targets I use. However, I still need to manually set `CMAKE_C_COMPILER_TARGET` or add `--target` to `CMAKE_C_FLAGS` for some targets, which I think somewhat defeats the purpose of this patch.


Yes, this is a known issue (tm) with the current CMake approach. :(

> So, I don't mind this change being merged, as it won't break anything, as far as I can tell, but I don't think it will fully solve the problems you're trying to solve by using it.


I agree.

Chris, I'm also ok with this going in if you know where you're going with it. I know of the problems, but I don't have any solution, sorry. So I'll trust you know better than me (even if it's just a gut feeling), we can easily change later to a better solution.

I'm accepting the revision in that respect.

cheers,
--renato


https://reviews.llvm.org/D24156