[PATCH] D22726: [DAGCombine] Match shift amount by value rather than relying on common sub-expressions.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 08:21:41 PDT 2016


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D22726#519454, @RKSimon wrote:

> In https://reviews.llvm.org/D22726#518905, @bryant wrote:
>
> > No. There are earlier combine rules that match specifically match on `iN, N > 64` that distort the `(shl (srl x, c), c)` pattern.
>
>
> Are you saying that they prevent the combine from happening or that the earlier combines assert due to still using getZExtValue() ?


These have been dealt with so I think this patch is ready to go.


Repository:
  rL LLVM

https://reviews.llvm.org/D22726





More information about the llvm-commits mailing list