[PATCH] D24216: AMDGPU: Partially fix control flow at -O0
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 13 21:09:39 PDT 2016
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/SILowerControlFlow.cpp:221-224
@@ -172,5 +220,6 @@
MachineInstr *OrSaveExec =
BuildMI(MBB, Start, DL, TII->get(AMDGPU::S_OR_SAVEEXEC_B64), DstReg)
- .addOperand(MI.getOperand(1)); // Saved EXEC
+ .addReg(DstReg);
+
MachineBasicBlock *DestBB = MI.getOperand(2).getMBB();
----------------
nhaehnle wrote:
> Did you run clang-format-diff on this? I think it will complain about the formatting. (I'm personally rather annoyed at the fact that it does, but we should play by the rules...)
I tried removing the tied and 5 tests fail with verifier errors (all Live segment doesn't end at a valid instruction). I think trying to fix these is a separate patch
https://reviews.llvm.org/D24216
More information about the llvm-commits
mailing list