[PATCH] D21987: [XRay] Implement `llvm-xray extract`, start of the llvm-xray tool

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 22:25:28 PDT 2016


dberris added inline comments.

================
Comment at: tools/llvm-xray/xray-sleds.h:20-26
@@ +19,9 @@
+
+struct XRaySledEntry {
+  uint64_t Address;
+  uint64_t Function;
+  unsigned char Kind;
+  unsigned char AlwaysInstrument;
+  unsigned char Padding[14];
+};
+
----------------
majnemer wrote:
> This seems problematic, the fields should probably be ulittle64_t, etc..  This way they have the correct endianness and alignment.
Interesting -- can we use `ulittle64_t` in compiler-rt as well?


https://reviews.llvm.org/D21987





More information about the llvm-commits mailing list