[PATCH] D24471: [ELF] Set EF_ARM_EABI_VER5 for ARM

[Rui Ueyama via llvm-commits]

ruiu added a comment.

LGTM.

Thanks a lot Peter, your explanation was extremely useful to understand the situation.


================
Comment at: ELF/Writer.cpp:1267
@@ +1266,3 @@
+    // We don't currently use any features incompatible with EF_ARM_EABI_VER5,
+    // but we don't have any firm guarantees of conformance.
+    EHdr->e_flags = EF_ARM_EABI_VER5;
----------------
Please also add a comment to describe why we need to set this value and can't leave as zero. Linux/AArch64 as of 2016 doesn't accept e_flags with zero.


https://reviews.llvm.org/D24471