[PATCH] D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute

Victor Leschuk via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 12:35:51 PDT 2016


vleschuk added a comment.

In https://reviews.llvm.org/D24425#540448, @dblaikie wrote:

> This might be a bit easier to review if it were broken into separate patches - it looks like there's orthogonal functionality in here (ie: some code to add the alignment attribute to global variables, some to add it to types, etc) - is that the case? Do those changes have some pieces in common that needs to be staged together in some way?


Yep, some code can be moved to  separate patch. Will create a new review and put it into relationship with this one. Thanks for advice.


https://reviews.llvm.org/D24425





More information about the llvm-commits mailing list