[PATCH] D24478: [CodeGen] Fix invalid shift in mul expansion

Paweł Bylica via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 04:26:13 PDT 2016


chfast added inline comments.

================
Comment at: test/CodeGen/X86/mul-bigint.ll:1
@@ +1,2 @@
+; RUN: llc < %s | FileCheck %s
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
RKSimon wrote:
> Call this file mul-i512.ll to match the existing filenames?
> 
> Test on 32-bit targets as well if you can and use utils/update_llc_test_checks.py to generate the output
To test on both 32-bit and 64-bit targets should I do something like:
```
; RUN llc < %s -mtriple=x86_64-unknown-linux-gnu
; RUN llc < %s -mtriple=x86-unknown-linux-gnu
```
?


Repository:
  rL LLVM

https://reviews.llvm.org/D24478





More information about the llvm-commits mailing list