[PATCH] D24471: [ELF] Set EF_ARM_EABI_VER5 for ARM

[Renato Golin via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D24471#540946, @peter.smith wrote:

> I think the current value of EF_ARM_ABI_VERSION = 0 is honest, as the ARM port is incomplete and we can't make any firm statements of conformance right now. In practice all input objects given to lld will be EF_ARM_ABI_VERSION 5 and we don't make use of any features that are incompatible with EF_ARM_ABI_VERSION 5 so I think it is acceptable to set the default to 5 as long as we leave an appropriate comment.


Well, I take it the kernel interprets this flag as being "what I intend to implement", not "what I honestly can implement".

In that case, 5 is the *correct* value, given the users' interpretation, not the ABI. We've been into that situation before with regards to architecture support and the approach was similar: state what we intend to do and fix the bugs as we find them.

Since we don't have a full conformance test-suite, exaggerating the statement and complete later is the only thing we can reliably do.

I agree the comment expresses it well and is necessary.

cheers,
--renato


https://reviews.llvm.org/D24471