[PATCH] D24471: [ELF] Set EF_ARM_EABI_VER5 for ARM

[Martin Storsjö via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D24471#540946, @peter.smith wrote:

> Strictly speaking EF_ARM_EABI version It is a bit more than an implementation detail. The current value of 0 is more honest, however it may be less useful in practice.


What I meant was that the fact that the aarch64 kernel refuses to run binaries with a zero version is an implementation detail.

> I think the current value of EF_ARM_ABI_VERSION = 0 is honest, as the ARM port is incomplete and we can't make any firm statements of conformance right now. In practice all input objects given to lld will be EF_ARM_ABI_VERSION 5 and we don't make use of any features that are incompatible with EF_ARM_ABI_VERSION 5 so I think it is acceptable to set the default to 5 as long as we leave an appropriate comment.


Thanks for the good writeup!

What would be a useful but concise enough comment here? "// We don't currently use any features incompatible with EF_ARM_EABI_VER5, but we don't have any firm guarantees of conformance"


https://reviews.llvm.org/D24471