[PATCH] D24298: [ELF] Linkerscript: Implement LOADADDR

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.

================
Comment at: ELF/LinkerScript.cpp:431
@@ -416,3 +430,3 @@
 
       if ((Sec->getFlags() & SHF_TLS) && Sec->getType() == SHT_NOBITS) {
         uintX_t TVA = Dot + ThreadBssOffset;
----------------
This wasn't needed, because setLMAOffset is called in SetAddrs(). See lines 399 - 403

================
Comment at: ELF/Writer.cpp:1003-1004
@@ -992,4 +1002,4 @@
     uintX_t NewFlags = Sec->getPhdrFlags();
-    if (Script<ELFT>::X->getLma(Sec->getName()) || Flags != NewFlags) {
+    if (HasLMA || Flags != NewFlags) {
       Load = AddHdr(PT_LOAD, NewFlags);
       Flags = NewFlags;
----------------
See lines 987-995


https://reviews.llvm.org/D24298