[llvm] r281289 - [lib/LTO] Expose getModule() in lto::InputFile.

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 20:51:47 PDT 2016



Sent from my iPhone

> On Sep 12, 2016, at 8:13 PM, Davide Italiano <davide at freebsd.org> wrote:
> 
>> On Mon, Sep 12, 2016 at 8:05 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:
>> Sneaky ping on https://reviews.llvm.org/D23132 :)
>> 
>> (In the meantime: +1 to Peter, please revert)
>> 
> 
> This patch is not breaking any buildbot

That's not a criteria.

> and it's very unlikely that's
> is gonna be used by anything outside of lld

As long as I delete this API without updating your client code, that's fine with me...

-- 
Mehdi

> (
> https://reviews.llvm.org/D24492), at least for the time being. I
> proposed an alternative solution, i.e. moving this to the LTO library,
> so I'd like to have your opinion about it before considering a revert.
> 
> Thanks,
> 
> -- 
> Davide
> 
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160912/b3585b09/attachment.html>


More information about the llvm-commits mailing list