[PATCH] D24267: [ELF] - Added support of --gdb-index command line option.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 15:24:30 PDT 2016


If you can separate --gdb-index as a separate patch, please do.

On Sat, Sep 10, 2016 at 1:26 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> grimar added a comment.
>
> In https://reviews.llvm.org/D24267#538684, @ruiu wrote:
>
> > I'm still reading this patch and haven't got the whole picture yet. A
> few swing-by comments. Please do it incrementally next time. You don't need
> to make up a complete, working code from day one -- but you can
> incrementally build a feature in the public repository, and it is actually
> more appreciated way of doing it than dropping a complete large patch out
> of the blue.
>
>
> I am really sorry, do not want inconvenience for anyone. My suggestion is
> next then. What if I`ll split this patch to several ? I mean them will not
> be workable, first one can just generate the gdb_index section itself and
> some part of data. So it can be a sequence of patches which will make the
> functionality workable after the last one is committed.
> What do you think ?
>
>
> https://reviews.llvm.org/D24267
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160912/78452a6a/attachment.html>


More information about the llvm-commits mailing list