[zorg] r280761 - Downgrade tsan_analyze step to warnings to fix the bot

[Kostya Serebryany via llvm-commits]

Thank you Ivan and James!

--kcc

On Sun, Sep 11, 2016 at 12:39 PM, Ivan Krasin <krasin at google.com> wrote:

> r281174
>
> On Fri, Sep 9, 2016 at 6:47 PM, Ivan Krasin <krasin at google.com> wrote:
>
>> Okay, will do on Monday.
>>
>> On Fri, Sep 9, 2016 at 6:40 PM, Kostya Serebryany <kcc at google.com> wrote:
>>
>>>
>>>
>>>
>>>
>>> On Fri, Sep 9, 2016 at 6:21 PM, Ivan Krasin <krasin at google.com> wrote:
>>>
>>>> To clarify: the test is enabled and running. It just does not make the
>>>> bot red. Notice the yellow stage here: http://lab.llvm.org:8011
>>>> /builders/sanitizer-x86_64-linux-autoconf/builds/25080
>>>>
>>>
>>> Yep. So, I want it to start tolerating the current situation.
>>> If the current situation degrades further *or improves* the test should
>>> go red.
>>> (If it improves, we will change it again)
>>>
>>>
>>>>
>>>> On Fri, Sep 9, 2016 at 6:19 PM, Kostya Serebryany <kcc at google.com>
>>>> wrote:
>>>>
>>>>> +James Molloy, dvyukov
>>>>>
>>>>> Ooook...
>>>>>
>>>>> Looks like there are lots of reasons to not revert the change that
>>>>> regressed this. (https://llvm.org/bugs/show_bug.cgi?id=30244)
>>>>> Ivan, may I ask you modify the test so that it passes now and enable
>>>>> it back?
>>>>> This way we'll at least know if it regresses further and also if it
>>>>> improves.
>>>>>
>>>>> --kcc
>>>>>
>>>>>
>>>>>
>>>>> On Thu, Sep 8, 2016 at 3:26 PM, Ivan Krasin <krasin at google.com> wrote:
>>>>>
>>>>>> Not yet. The codegen bug is still not fixed: https://llvm.org/bugs/s
>>>>>> how_bug.cgi?id=30244 and the issue still happening:
>>>>>> http://lab.llvm.org:8011/builders/sanitizer-x86_6
>>>>>> 4-linux-autoconf/builds/25007/steps/tsan%20analyze/logs/stdio
>>>>>>
>>>>>> Dmitry Vyukov posted a short reproducer today, that should help with
>>>>>> tracking down the regression.
>>>>>> After the bug is closed, I will revert my CL.
>>>>>>
>>>>>> On Thu, Sep 8, 2016 at 2:53 PM, Kostya Serebryany <kcc at google.com>
>>>>>> wrote:
>>>>>>
>>>>>>> can this be reverted now?
>>>>>>>
>>>>>>> On Tue, Sep 6, 2016 at 3:19 PM, Ivan Krasin via llvm-commits <
>>>>>>> llvm-commits at lists.llvm.org> wrote:
>>>>>>>
>>>>>>>> Author: krasin
>>>>>>>> Date: Tue Sep  6 17:19:30 2016
>>>>>>>> New Revision: 280761
>>>>>>>>
>>>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=280761&view=rev
>>>>>>>> Log:
>>>>>>>> Downgrade tsan_analyze step to warnings to fix the bot
>>>>>>>>
>>>>>>>> Summary:
>>>>>>>> tsan_analyze identified a codegen regression that is being
>>>>>>>> discussed in https://llvm.org/bugs/show_bug.cgi?id=30244.
>>>>>>>> This change downgrades the check from failure to warnings to
>>>>>>>> make the bot happy.
>>>>>>>>
>>>>>>>> Reviewers: dvyukov
>>>>>>>>
>>>>>>>> Differential Revision: https://reviews.llvm.org/D24281
>>>>>>>>
>>>>>>>> Modified:
>>>>>>>>     zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_standa
>>>>>>>> rd.sh
>>>>>>>>
>>>>>>>> Modified: zorg/trunk/zorg/buildbot/build
>>>>>>>> ers/sanitizers/buildbot_standard.sh
>>>>>>>> URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot
>>>>>>>> /builders/sanitizers/buildbot_standard.sh?rev=280761&r1=2807
>>>>>>>> 60&r2=280761&view=diff
>>>>>>>> ============================================================
>>>>>>>> ==================
>>>>>>>> --- zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_standard.sh
>>>>>>>> (original)
>>>>>>>> +++ zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_standard.sh
>>>>>>>> Tue Sep  6 17:19:30 2016
>>>>>>>> @@ -64,4 +64,4 @@ build_tsan "${TSAN_RELEASE_BUILD_DIR}" "
>>>>>>>>  echo @@@BUILD_STEP tsan analyze@@@
>>>>>>>>  BIN=$(mktemp -t tsan_exe.XXXXXXXX)
>>>>>>>>  echo "int main() {return 0;}" | $TSAN_RELEASE_BUILD_DIR/bin/clang
>>>>>>>> -x c++ - -fsanitize=thread -O2 -o ${BIN}
>>>>>>>> -$LLVM_CHECKOUT/projects/compiler-rt/lib/tsan/check_analyze.sh
>>>>>>>> ${BIN} || echo @@@STEP_FAILURE@@@
>>>>>>>> +$LLVM_CHECKOUT/projects/compiler-rt/lib/tsan/check_analyze.sh
>>>>>>>> ${BIN} || echo @@@STEP_WARNINGS@@@
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> llvm-commits mailing list
>>>>>>>> llvm-commits at lists.llvm.org
>>>>>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160912/1d319ccf/attachment.html>