[PATCH] D24294: [ELF] - Implemented --section-start, -Ttext, -Tdata, -Tbss options.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:382
@@ -381,1 +381,3 @@
 
+static uint64_t parseSectionAddress(StringRef S, const Twine &Err) {
+  uint64_t VA = 0;
----------------
So I think you want to pass `opt::Arg *Arg` as the second argument, and

================
Comment at: ELF/Driver.cpp:387
@@ +386,3 @@
+  if (S.getAsInteger(16, VA))
+    error(Err);
+  return VA;
----------------
do

  error("invalid argument: " + stringize(Arg));

================
Comment at: ELF/Driver.cpp:403-405
@@ +402,5 @@
+  if (auto *Arg = Args.getLastArg(OPT_Ttext))
+    Ret[".text"] = parseSectionAddress(Arg->getValue(),
+                                       Twine("invalid argument for -Ttext: ") +
+                                           Arg->getValue());
+  if (auto *Arg = Args.getLastArg(OPT_Tdata))
----------------
This doesn't look very beautiful.


https://reviews.llvm.org/D24294